Place all generated files in separate GENERATED list, so they all can… #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at the tests, it would appear that both Presumably you intended this code to also handle the output of custom build rules. If so, could you add a test to show that? I'd like to see a case where |
… be cleaned by clean target.
|
Thank you for feedback. I added |
starkos
approved these changes
Mar 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… be cleaned by clean target.
What does this PR do?
All files generated by regular or custom rules for gmake2/cpp projects will be placed in separate GENERATED list, and will be deleted on
make cleaninvocation.How does this PR change Premake's behavior?
All files generated by custom rules for gmake2/cpp will be deleted on
make cleaninvocationAre there any breaking changes? Will any existing behavior change?
Probably no. Yes, previously buildoutputs of custom rules gmake2/cpp was persisted after
make cleannow they will be deleted.Anything else we should know?
I use tolua for lua-c++ bindings, with this change generated files will be properly cleaned on
make cleanstep.closes #1380
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!